Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow effects introduce performance issues #238

Closed
juzzlin opened this issue Mar 14, 2023 · 7 comments
Closed

Shadow effects introduce performance issues #238

juzzlin opened this issue Mar 14, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@juzzlin
Copy link
Owner

juzzlin commented Mar 14, 2023

There could be an easier way to disable the shadow effects (maybe just a button that sets the shadow parameters to zero) + probably we'd need a border color for the nodes to give some contrast.

@juzzlin
Copy link
Owner Author

juzzlin commented Mar 14, 2023

Workaround for this is to go to File => Settings => Effects and set Shadow effect offset and Shadow blur radius to zero.

@juzzlin
Copy link
Owner Author

juzzlin commented Mar 14, 2023

This at tries to fix the issue:

03712c8

@juzzlin juzzlin closed this as completed Mar 14, 2023
@elandorr
Copy link

I had already disabled the effects, but that didn't change too much. The issue only arises when zoomed in for some reason. The full map with all the lines over each other is fast.

@juzzlin
Copy link
Owner Author

juzzlin commented Mar 14, 2023

Could you please send or attach an example map with the problem so I could try to reproduce?

@elandorr
Copy link

https://oshi.at/mhgg

Restarting reduced memory consumption <200MB. Not sure the content had anything to do with it, had to clean it. It was mostly a maximum of 2 lines, most just one line, nothing dramatic.

@l3td33r
Copy link
Contributor

l3td33r commented Mar 18, 2023

I had already disabled the effects, but that didn't change too much. The issue only arises when zoomed in for some reason. The full map with all the lines over each other is fast.

Related to #141 ?

@elandorr
Copy link

@l3td33r Looks like it. 4.1 with shadows off is definitely an improvement! Thanks for fixing the dragging by the way, that works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants