Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New io-datatype File (UAC-1 of #123) #125

Merged
merged 5 commits into from
Feb 5, 2023

Conversation

schlingling
Copy link
Contributor

@schlingling schlingling commented Feb 5, 2023

Introduces a new io-datatype File

Part of RFC0002 mobility-extension.

Implements following UACs of #123:

  • [UAC-1] New io-datatype File is implemented.

@schlingling schlingling self-assigned this Feb 5, 2023
@schlingling schlingling changed the title New io-datatype File New io-datatype File (UAC-1 of #123) Feb 5, 2023
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File type should be an enum of strings i think, can be only octed stream for now. Same with extension so that we avoid the issues of different values due to people using different capitalizations.

I'll approve this so you can merge this without re-requesting a review when you make the enum changes.

@schlingling schlingling merged commit 1706112 into main Feb 5, 2023
@schlingling schlingling deleted the feat-mobility-extension-uac-1 branch February 5, 2023 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
@schlingling
Copy link
Contributor Author

File type should be an enum of strings i think, can be only octed stream for now. Same with extension so that we avoid the issues of different values due to people using different capitalizations.

I'll approve this so you can merge this without re-requesting a review when you make the enum changes.

Fyi, i will change the enums again in #126 to a version without Keys, this makes it easier for us when using Files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants