New blocktype HttpExtractor (UAC-09 of #123) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlingling
changed the title
schlingling
changed the title
This was referenced Feb 12, 2023
rhazn
requested changes
Feb 13, 2023
schlingling
commented
Feb 13, 2023
rhazn
approved these changes
Feb 13, 2023
| @@ -58,10 +58,10 @@ export class ArchiveInterpreterExecutor extends BlockExecutor< | |||
| // Filename without ext and dot | |||
| const fileName = path.basename(archivedObject.name, extName); | |||
| const mimeType = | |||
| inferMimeTypeFromFileExtension(extName) || | |||
| inferMimeTypeFromString(extName) || | |||
There was a problem hiding this comment.
FromFileExtension, it's not a random string ;)
There was a problem hiding this comment.
will shipp this via the next PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new blocktype
HttpExtractorPart of RFC0002 mobility-extension.
Implements following UACs of #123:
HttpExtractoris implemented in std-extension.I was not sure, how to register the new Block properly, so i will register it later.
Minor changes besides: