-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New blocktype FilePicker and abort mechanism (UAC-7-11 of #123) #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment, once that is fixed this is fine to merge.
Please add documentation to the added |
added doc to FilePicker @georg-schwarz. Thanks for already adding the docs to my HttpExtractor and ArchiveInterpreter :) |
@rhazn: I implemented the changes discussed in slack (return null value in filepicker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from my side, please wait for felix to have a look at the one comment I tagged him in.
{ | ||
code: blockExampleUsage, | ||
description: | ||
'A local SQLite file is created at the given path and filled with table data about cars.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a correct description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn, copy/paste-error, sorry! Will change it.
result.left.message, | ||
result.left.diagnostic, | ||
// Check, if parent emitted a value | ||
if (inputValue != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question for @felix-oq as well I think.
I see:
- Blocks could return combined types, e.g.
FILE | NONE
and we abort execution onNONE
, this is the view "A block always has an output if it gets executed" - Blocks could return their output as
FILE
and also return nothing (in the typescript interpreters casenull
), this is the view "A block generates zero or more outputs on any input"
I personally think generating zero or more outputs for any input is the best. I know it from observables, it is very helpful later on because in a lot of cases you might want to generate multiple values for one input.
While the best way to implement that would be with the actual 0 to n outputs, I think a first iteration with 1 output or null for 0 outputs is fine.
So in summary, I like the usage of returning FILE
or null
here and would keep it but please, @felix-oq have a look and share your opinion as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense for me, will wait for felix, thanks for your input!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, we can do it like that 👍
Introduces a new blocktype
FilePicker
and abort mechanism if an parent block emits a null value.Part of RFC0002 mobility-extension.
Implements following UACs of #123:
I was not sure, how to register the new Block properly, so i will register it later.