Implement postgres loader #23
Conversation
| @@ -0,0 +1,39 @@ | |||
| import { DataTypeVisitor } from './DataTypeVisitor'; | |||
|
|
|||
| export class PostgresValueRepresentationVisitor extends DataTypeVisitor< | |||
There was a problem hiding this comment.
This is a "weird" implementation right now. Essentially I return a function that takes an unknown value and returns a representation of that value (when looked at as being of the DataType) for postgresql.
I like this in the sense of the postgres specific part being in this visitor.
I dislike it for basically needing to handle all possibly "valid" values of a ValueType. This should probably be standardized by the valuetype first.
There was a problem hiding this comment.
I updated this to force valuetypes to provide a standardized representation of values first. I think this way is nicer.
| @@ -62,7 +62,9 @@ | |||
| "chevrotain": "^9.1.0", | |||
| "commander": "^8.0.0", | |||
| "fast-csv": "^4.3.6", | |||
| "fp-ts": "^2.13.1", | |||
There was a problem hiding this comment.
This sadly also includes most of Georgs commits for error handling so it is easier to merge into main once we merge.
There was a problem hiding this comment.
LGTM, I like the way you applied the visitor pattern to derive the postgres column types 🥇
We should further think about the distinction / combination of types for block in-/output in data-types.ts and the primitive types in AbstractDataType.ts. But that probably is beyond the scope of this PR.
|
I agree, I moved this to a new issue in #24 24 |
closes #10