Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unique name validation #576

Merged
merged 10 commits into from
May 29, 2024
Merged

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented May 29, 2024

Addresses parts of #572.
Adds parts of #563.

@georg-schwarz georg-schwarz marked this pull request as ready for review May 29, 2024 12:04
@georg-schwarz georg-schwarz force-pushed the refactor-unique-name-validation branch from 40fccaf to 800e2bf Compare May 29, 2024 13:46
@georg-schwarz georg-schwarz requested a review from rhazn May 29, 2024 13:46
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, again just left nitpicky comments so happy for you to ignore them and merge it like this as well 👍 .

@georg-schwarz georg-schwarz merged commit daa04b5 into main May 29, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the refactor-unique-name-validation branch May 29, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants