Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSVFIleLoader block #598

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Add CSVFIleLoader block #598

merged 6 commits into from
Jul 9, 2024

Conversation

TungstnBallon
Copy link
Contributor

@TungstnBallon TungstnBallon commented Jul 2, 2024 •
edited
Loading

This PR adds a the ability to export tables into csv files using fast-csv, the same library that parses the csv in CSVIntperpreter.

closes #394

TODO before merging:

@TungstnBallon TungstnBallon self-assigned this Jul 2, 2024
@TungstnBallon TungstnBallon linked an issue Jul 2, 2024 that may be closed by this pull request
[FEATURE] Save table as CSV #394
Closed
6 tasks
@TungstnBallon TungstnBallon force-pushed the 394-feature-save-table-as-csv branch 4 times, most recently from 068d6a0 to 76cd4d9 Compare July 4, 2024 09:11
@TungstnBallon TungstnBallon marked this pull request as ready for review July 4, 2024 09:19
@TungstnBallon TungstnBallon requested a review from rhazn July 4, 2024 09:20
rhazn
rhazn requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the commit you already identified (no need to commit local test files) and write 1-2 more tests but otherwise looks good to me 👍

@TungstnBallon TungstnBallon force-pushed the 394-feature-save-table-as-csv branch from 9bd07e1 to 177f4ef Compare July 9, 2024 07:26
@TungstnBallon TungstnBallon requested a review from rhazn July 9, 2024 07:37
@TungstnBallon TungstnBallon force-pushed the 394-feature-save-table-as-csv branch from 177f4ef to 833ae63 Compare July 9, 2024 08:30
@TungstnBallon TungstnBallon merged commit 0cc48c7 into main Jul 9, 2024
3 checks passed
@TungstnBallon TungstnBallon deleted the 394-feature-save-table-as-csv branch July 9, 2024 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhazn rhazn rhazn approved these changes

Assignees

@TungstnBallon TungstnBallon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Save table as CSV
2 participants
@TungstnBallon @rhazn