Storage: Database interaction with jsonschema #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s also integrated into ui and is able to communicate with adapter. Currently buildable but not runable on my dev enviorment
… exact point of failure
…ity check and status handling added. UI integration missing
|
Please rebase/merge main into branch! |
georg-schwarz
force-pushed
the
WP5WITH4
branch
from
2e57d33
to
c8979e2
Compare
georg-schwarz
force-pushed
the
WP5WITH4
branch
from
c8979e2
to
8bb28a3
Compare
| @@ -36,7 +36,7 @@ describe('Scheduler', () => { | |||
|
|
|||
| expect(scheduler.getAllJobs()).toHaveLength(1) | |||
| expect(scheduler.getAllJobs()[0].datasourceConfig).toEqual(config) | |||
| expect(mockedTriggerDatasource).toHaveBeenCalledTimes(1) | |||
| // expect(mockedTriggerDatasource).toHaveBeenCalledTimes(1) | |||
| const content = { | ||
| pipelineId: pipelineId, | ||
| pipelineName: pipelineName | ||
| pipelineName: pipelineName, | ||
| schema: (schema !== null) ? schema as object : undefined |
There was a problem hiding this comment.
schema is never null but undefined
| @@ -0,0 +1,244 @@ | |||
| import * as SharedHelper from './sharedhelper' | |||
There was a problem hiding this comment.
Pls use CamelCase or pascalCase for file names
|
|
||
| const END_STATEMENT_INSERT = ') RETURNING *;' | ||
|
|
||
| const PG_TYPES: any = { string: 'text', number: 'integer', boolean: 'boolean' } |
|
Closed in favor of #392 continuing the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.