Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete and useless code #194

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Remove obsolete and useless code #194

merged 2 commits into from
Sep 16, 2020

Conversation

sonallux
Copy link
Contributor

  • Remove obsolete usage of NodeJS --max-http-header-size parameter
  • Remove useless wrapping of the return value with Promise.reject(...) or Promise.resolve(...) in async functions
  • Move sleep() function to its own file, so it is not redefined multiple times

georg-schwarz
georg-schwarz requested changes Sep 16, 2020
View reviewed changes
storage/storage-mq/src/sleep.ts Outdated Show resolved Hide resolved
georg-schwarz
georg-schwarz approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@georg-schwarz georg-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@georg-schwarz georg-schwarz merged commit 92a45f4 into jvalue:master Sep 16, 2020
@sonallux sonallux deleted the remove-obsolete-code branch September 16, 2020 09:32
georg-schwarz added a commit that referenced this pull request Feb 12, 2021
@georg-schwarz
Remove obsolete and useless code (#194)
e999eb5 
* Remove obsolete and useless code

* Fix documentation of sleep function
georg-schwarz pushed a commit that referenced this pull request Feb 12, 2021
@jsone-studios
Remove obsolete and useless code (#194)
f7ebc12 
* Remove obsolete and useless code

* Fix documentation of sleep function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georg-schwarz georg-schwarz georg-schwarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonallux @georg-schwarz @jsone-studios