fix(directive): releasing $timeout on remove()

[sfount]

This commit uses the Angular $timeout service to clear the timer (set by the growl directives link method) when the $growlNotification.remove() method is called. Ensuring this removal propagates and is respected by Angular's digest loop.

Solution:
Replace

this.timer.cancel()

with

$timeout.cancel(this.timer)

to ensure the timer is cleaned up within Angular.

Problem:
When testing an Angular application with Protractor there is a default configuration ignoreSynchronization that is set to false - this means that Protractor will watch Angular's services $http, $timeout etc. and wait until promises are resolved before continuing the test. In the current implementation the $timeout set in the directive

ctrl.timer = $timeout(//...

is never actually cleared when $growlNotification.remove() is called - this means end to end tests will wait until the ttl has been completed and the $timeout is cleaned up automatically (it is worth noting the call to $animate works fine so it actually looks like the notification is removed!).

[jvandemo]

@sfount — Thank you, excellent work and great PR. Much appreciated! 👍

[jvandemo]

Merged and released as v2.4.0. Thank you @sfount!

[sfount]

Cheers @jvandemo. This is a great unopinionated library!