Add directive to update link tag #18

khisakuni · 2016-05-02T16:03:00Z

Update link elements

Add UpdateLinkDirective to update link
Extract logic for updating an attribute into UpdateAttributeService
Update example

- add new directive - add service to update attribute of element - update example

jvandemo · 2016-06-06T16:28:52Z

@khisakuni — I totally missed this, sorry. This looks great!

Am I correct in assuming that this would also make #20 possible? Thank you!

khisakuni · 2016-06-06T17:28:00Z

@jvandemo Yeah sounds like this issue is covered by this PR

khisakuni · 2016-06-13T20:10:16Z

@jvandemo ping

jvandemo · 2016-06-14T05:50:45Z

@khisakuni — I'll have a look at this today 👍

jvandemo · 2016-06-15T09:22:48Z

@khisakuni — I have finally had a chance to look at this. Great work! I have a couple of questions:

1. How can we target different link elements with same `rel`?

Due to the nature of link elements, it is sometimes not possible to identify them using only the rel attribute. Suppose you have:

<head>
  <link rel="stylesheet" href="styles1.css" />
  <link rel="stylesheet" href="styles2.css" />
</head>

and:

<update-link rel="stylesheet" href="styles3.css"></update-link>

then we get:

<head>
  <link rel="stylesheet" href="styles3.css" />
  <link rel="stylesheet" href="styles2.css" />
</head>

So the first element is always targeted, which could potentially not be the user's intention.

Would there be a way to target which element you want to update?

2. Support for other attributes?

The link element supports other attributes such as hreflang, see https://developer.mozilla.org/en/docs/Web/HTML/Element/link#Attributes for a complete list.

Would you be able to add support for them too?

I think your PR would be a great addition if both "issues" could be solved.

What do you think?

Thanks!

khisakuni · 2016-06-16T23:49:14Z

@jvandemo Thanks for taking a look!

I'll look into the things you mentioned and keep you posted.

jvandemo · 2016-06-17T17:54:18Z

@khisakuni — Thank YOU for making this happen!

rolintoucour · 2016-08-16T15:33:30Z

Hi and thanks for your work. I also need need this function, is it possible to merge it into the trunk?

jvandemo · 2016-08-24T09:47:55Z

@rolintoucour — The current status of this PR is not ready to be merged into master yet as @khisakuni is still working on it. If you need the functionality already, you can manually use the code from this PR to create your own custom library. Thanks!

khisakuni · 2016-09-27T15:11:19Z

@jvandemo sorry it took me a while to get around to this. Added support for specifying a link with an id attribute. So if there are two stylesheet links:

<link rel="stylesheet" href="styles1.css" />
<link rel="stylesheet" href="styles2.css" id="foobar" />

and you have

<update-link rel="stylesheet" href="styles3.css" id="foobar" ></ update-link>

it will query the DOM using the provided id.

This now also supports attributes found here.

<update-link  rel="test" href="http://example.com" hreflang="es"></ update-link>

will update both the href and the hreflang attributes.

Let me know what you think!

jvandemo · 2016-09-28T12:13:41Z

@khisakuni — Fantastic work, this looks great.

I will simulate some scenarios to see if the outcome is as expected.

Thank you for your efforts!

jvandemo · 2016-10-28T08:20:16Z

@khisakuni — Thank you, this is awesome!

One final question before merging: can you write down the pattern that you use to figure out which element to target? Then we can update the documentation to describe how the elements are matched.

E.g. does it first try to match all attributes? And then also match on ID? What happens if 2 elements have the same ID but different attributes?

It would be great to have a list of all scenario's so we can document everything nicely before merging.

Thanks again for your wonderful contribution!

simonepri · 2016-12-18T10:47:17Z

@jvandemo , @khisakuni there are some news about the status of this PR ?
Thanks

jvandemo · 2016-12-21T13:22:05Z

@simonepri — We are waiting for @khisakuni to document the targeting pattern before we can merge this PR. Hopefully @khisakuni can chime in. Thank you!

khisakuni · 2016-12-21T16:08:06Z

@simonepri @jvandemo hey sorry guys, been pretty slammed with work. Will try to update tonight.

jvandemo · 2016-12-21T17:13:55Z

@khisakuni — No problem, take your time. We appreciate all the effort you put into this 👍

cesarvarela · 2017-02-01T20:15:20Z

news about this guys?

alee046 · 2017-03-23T00:50:46Z

Same, any updates?

jvandemo · 2017-03-26T21:42:04Z

@cesarvarela, @alee046 — Unfortunately, this can't be merged without proper documentation. Once the documentation is available, we can test proper behavior and merge if okay.

khisakuni · 2017-04-09T22:50:44Z

@jvandemo Apologies that I've neglected this for a while! I updated the documentation to reflect the changes in this PR.

jvandemo · 2017-04-15T07:19:46Z

@khisakuni — Thank you for your great work, much appreciated!

Your changes have been merged and released as v2.0.0. 👍

simonepri · 2017-04-15T07:53:03Z

@khisakuni Thank you

simonepri · 2017-04-29T16:04:48Z

@jvandemo I think you forgot to push it to bower:

jvandemo · 2017-04-30T12:54:11Z

@simonepri — Thank you, great catch. I re-created the tag.

Can you please try again and verify if it works as expected? Thank you!

Kohei Hisakuni and others added 5 commits May 2, 2016 08:57

Add directive to update link tag

0df5e93

- add new directive - add service to update attribute of element - update example

Add log dependency

d8e1d51

Cleanup

dca956b

Fix name error

cd277cb

Add new build

69aa555

jvandemo added the enhancement label Jun 15, 2016

Add support for other link attributes

2d043e4

marcoraddatz mentioned this pull request Oct 21, 2016

Canonical and hreflang #20

Closed

Update docs

b45e47c

jvandemo merged commit b65511a into jvandemo:master Apr 15, 2017

khisakuni mentioned this pull request May 17, 2017

Fixes update-link attribute #29

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add directive to update link tag #18

Add directive to update link tag #18

khisakuni commented May 2, 2016

jvandemo commented Jun 6, 2016

khisakuni commented Jun 6, 2016

khisakuni commented Jun 13, 2016

jvandemo commented Jun 14, 2016

jvandemo commented Jun 15, 2016

khisakuni commented Jun 16, 2016

jvandemo commented Jun 17, 2016

rolintoucour commented Aug 16, 2016

jvandemo commented Aug 24, 2016

khisakuni commented Sep 27, 2016

jvandemo commented Sep 28, 2016

jvandemo commented Oct 28, 2016

simonepri commented Dec 18, 2016

jvandemo commented Dec 21, 2016

khisakuni commented Dec 21, 2016

jvandemo commented Dec 21, 2016

cesarvarela commented Feb 1, 2017

alee046 commented Mar 23, 2017

jvandemo commented Mar 26, 2017

khisakuni commented Apr 9, 2017

jvandemo commented Apr 15, 2017

simonepri commented Apr 15, 2017

simonepri commented Apr 29, 2017

jvandemo commented Apr 30, 2017

Add directive to update link tag #18

Add directive to update link tag #18

Conversation

khisakuni commented May 2, 2016

Update link elements

jvandemo commented Jun 6, 2016

khisakuni commented Jun 6, 2016

khisakuni commented Jun 13, 2016

jvandemo commented Jun 14, 2016

jvandemo commented Jun 15, 2016

1. How can we target different link elements with same rel?

2. Support for other attributes?

khisakuni commented Jun 16, 2016

jvandemo commented Jun 17, 2016

rolintoucour commented Aug 16, 2016

jvandemo commented Aug 24, 2016

khisakuni commented Sep 27, 2016

jvandemo commented Sep 28, 2016

jvandemo commented Oct 28, 2016

simonepri commented Dec 18, 2016

jvandemo commented Dec 21, 2016

khisakuni commented Dec 21, 2016

jvandemo commented Dec 21, 2016

cesarvarela commented Feb 1, 2017

alee046 commented Mar 23, 2017

jvandemo commented Mar 26, 2017

khisakuni commented Apr 9, 2017

jvandemo commented Apr 15, 2017

simonepri commented Apr 15, 2017

simonepri commented Apr 29, 2017

jvandemo commented Apr 30, 2017

1. How can we target different link elements with same `rel`?