Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in IvMatrix44 rotation with axis angle #57

Closed
cbaggers opened this issue Feb 6, 2017 · 2 comments
Closed

Possible error in IvMatrix44 rotation with axis angle #57

cbaggers opened this issue Feb 6, 2017 · 2 comments
Assignees

Comments

@cbaggers
Copy link

cbaggers commented Feb 6, 2017

https://github.com/jvanverth/essentialmath/blob/master/src/common/IvMath/IvMatrix44.cpp#L575

float txy = tx*nAxis.y; float tyz = tx*nAxis.z; float txz = tx*nAxis.z;

this line looks suspect in that tyz and txz both equal tx*nAxis.z

Should it be float tyz = ty*nAxis.z or, as there is no further mutation, could we combine the values?

@jvanverth
Copy link
Owner

jvanverth commented Feb 7, 2017

Yes, it should be float txy = tx*nAxis.y; float tyz = ty*nAxis.z;

@jvanverth jvanverth self-assigned this Feb 7, 2017
@cbaggers
Copy link
Author

cbaggers commented Feb 7, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants