We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/jvanverth/essentialmath/blob/master/src/common/IvMath/IvMatrix44.cpp#L575
float txy = tx*nAxis.y; float tyz = tx*nAxis.z; float txz = tx*nAxis.z;
this line looks suspect in that tyz and txz both equal tx*nAxis.z
tyz
txz
tx*nAxis.z
Should it be float tyz = ty*nAxis.z or, as there is no further mutation, could we combine the values?
float tyz = ty*nAxis.z
The text was updated successfully, but these errors were encountered:
Yes, it should be float txy = tx*nAxis.y; float tyz = ty*nAxis.z;
float txy = tx*nAxis.y; float tyz = ty*nAxis.z;
Sorry, something went wrong.
Thanks!
jvanverth
No branches or pull requests
https://github.com/jvanverth/essentialmath/blob/master/src/common/IvMath/IvMatrix44.cpp#L575
this line looks suspect in that
tyz
andtxz
both equaltx*nAxis.z
Should it be
float tyz = ty*nAxis.z
or, as there is no further mutation, could we combine the values?The text was updated successfully, but these errors were encountered: