Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ major refactoring #23

Merged
merged 3 commits into from
Feb 9, 2023
Merged

♻️ major refactoring #23

merged 3 commits into from
Feb 9, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Feb 9, 2023

I'll document the changes tomorrow - a bit too tired now 🙃

Long story short -> used more traits & structs to provide more flexibility (& less duplicate code) yay! 🎉

-- did not add support for aarch64/arm (as I currently do not have access to my ARM testing device)

@jvdd jvdd mentioned this pull request Feb 9, 2023
23 tasks
@varon
Copy link
Contributor

varon commented Feb 9, 2023

I can assist with the ARM64 testing if you need.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 9, 2023

CodSpeed Performance Report

Merging #23 nans_v4 (a046743) will degrade performances by 82.7%.

Summary

🔥 0 improvements
❌ 2 regressions
✅ 42 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark nans_v3 nans_v4 Change
avx2_random_long_u32 402.9 µs 7,731.2 µs -1818.88%
impl_random_long_u32 403.1 µs 7,731.4 µs -1817.90%

@jvdd
Copy link
Owner Author

jvdd commented Feb 9, 2023

Would be very useful! @varon
It should be safe to look into adding support for ARM/Aarch64 for ints & uints from #21 (after this merge)

@jvdd
Copy link
Owner Author

jvdd commented Feb 9, 2023

I'll fix the u32 AVX2 regression in PR #21

@jvdd jvdd merged commit 97adc4f into nans_v3 Feb 9, 2023
@jvdd jvdd deleted the nans_v4 branch February 28, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants