Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove stdsimd feature; add stdarch_x86_avx512 #62

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

lazyky
Copy link
Contributor

@lazyky lazyky commented Feb 19, 2024

Closes #61

@jvdd
Copy link
Owner

jvdd commented Feb 19, 2024

Thanks for contributing this @lazyky!

I'm wondering if we could improve this by being backwards compatible with other rustc versions through using cfg_version (or smth similar)..

Copy link

codspeed-hq bot commented Feb 19, 2024

CodSpeed Performance Report

Merging #62 will degrade performances by 14.24%

Comparing lazyky:main (ae95499) with main (c4a4c3c)

Summary

⚡ 10 improvements
❌ 11 (👁 11) regressions
✅ 147 untouched benchmarks

Benchmarks breakdown

Benchmark main lazyky:main Change
sse_f16_argmax_in 495.5 µs 474.1 µs +4.51%
sse_f16_argmin_in 495.6 µs 474 µs +4.54%
👁 sse_f16_argminmax_in 602.7 µs 624 µs -3.41%
👁 scalar_f32_argminmax_rn 2.1 ms 2.4 ms -14.24%
👁 scalar_f64_argminmax_rn 2.2 ms 2.6 ms -13.26%
scalar_i16_argmax 1.2 ms 1.1 ms +11.95%
scalar_i16_argmin 1.2 ms 1.1 ms +11.95%
👁 avx2_i32_argmax 338.5 µs 349.2 µs -3.05%
👁 avx2_i32_argmin 338.5 µs 349.2 µs -3.04%
👁 impl_i32_argmax 338.7 µs 349.4 µs -3.06%
👁 impl_i32_argmin 338.8 µs 349.4 µs -3.04%
scalar_i8_argmax 1.2 ms 1.1 ms +11.97%
scalar_i8_argmin 1.2 ms 1.1 ms +11.97%
scalar_u16_argmax 1.2 ms 1.1 ms +11.95%
scalar_u16_argmin 1.2 ms 1.1 ms +11.95%
👁 avx2_u32_argmax 338.6 µs 349.2 µs -3.03%
👁 avx2_u32_argmin 338.6 µs 349.2 µs -3.04%
👁 impl_u32_argmax 338.8 µs 349.4 µs -3.03%
👁 impl_u32_argmin 338.8 µs 349.5 µs -3.05%
scalar_u8_argmax 1.2 ms 1.1 ms +11.97%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@lazyky
Copy link
Contributor Author

lazyky commented Feb 20, 2024

According to rust-lang/stdarch#1486:

  • Split the stdsimd feature

Copy link
Owner

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If all tests pass, this one will be merged.

(P.S.: sorry for spamming some commits)

@jvdd jvdd merged commit 868600f into jvdd:main Feb 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly feature stdsimd has been removed
2 participants