Skip to content

Commit

Permalink
[networkimage] Standardize the delegate error method name.
Browse files Browse the repository at this point in the history
Closes #177.
  • Loading branch information
jverkoey committed Mar 21, 2012
1 parent 07182f7 commit 65fa7fb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/networkimage/src/NINetworkImageView.h
Expand Up @@ -137,7 +137,7 @@ typedef enum {

- (void)networkImageViewDidStartLoading;
- (void)networkImageViewDidLoadImage:(UIImage *)image;
- (void)networkImageViewDidFailToLoad:(NSError *)error;
- (void)networkImageViewDidFailWithError:(NSError *)error;

@end

Expand All @@ -163,7 +163,7 @@ typedef enum {
/**
* The asynchronous download failed.
*/
- (void)networkImageViewDidFailLoad:(NINetworkImageView *)imageView;
- (void)networkImageView:(NINetworkImageView *)imageView didFailWithError:(NSError *)error;

@end

Expand Down Expand Up @@ -686,5 +686,5 @@ typedef enum {
/**
* A network request failed to load.
*
* @fn NINetworkImageView::networkImageViewDidFailToLoad:
* @fn NINetworkImageView::networkImageViewDidFailWithError:
*/
8 changes: 4 additions & 4 deletions src/networkimage/src/NINetworkImageView.m
Expand Up @@ -217,11 +217,11 @@ - (void)_didFinishLoadingWithImage: (UIImage *)image
- (void)_didFailToLoadWithError:(NSError *)error {
self.operation = nil;

if ([self.delegate respondsToSelector:@selector(networkImageViewDidFailLoad:)]) {
[self.delegate networkImageViewDidFailLoad:error];
if ([self.delegate respondsToSelector:@selector(networkImageView:didFailWithError:)]) {
[self.delegate networkImageView:self didFailWithError:error];
}

[self networkImageViewDidFailToLoad:error];
[self networkImageViewDidFailWithError:error];
}


Expand Down Expand Up @@ -273,7 +273,7 @@ - (void)networkImageViewDidLoadImage:(UIImage *)image {


///////////////////////////////////////////////////////////////////////////////////////////////////
- (void)networkImageViewDidFailToLoad:(NSError *)error {
- (void)networkImageViewDidFailWithError:(NSError *)error {
// No-op. Meant to be overridden.
}

Expand Down

0 comments on commit 65fa7fb

Please sign in to comment.