Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

generate_namespace_generator filtering necessary symbols #653

Closed
phillip-martin opened this issue Jun 21, 2016 · 0 comments
Closed

generate_namespace_generator filtering necessary symbols #653

phillip-martin opened this issue Jun 21, 2016 · 0 comments

Comments

@phillip-martin
Copy link

First of all, I just want to say that I've found the script gnerate_namespace_generator to be very helpful in my own work. So thank you for providing it in the nimbus repo.

I also appreciate that the filters are documented (e.g. grep -v "\$_NS" on line 43). This makes it very clear what symbols the script wants to avoid adding to the namespace header file. Only one filter, grep -v ".eh" (on line 71) is undocumented (as far as I could find).

The only reason I discovered this was that this script (or I should say a slightly modified version of it), was filtering out symbols like "filehandle", which matches ".eh". I assume this wasn't the intended behavior of the filter but I also assume that it was included for a good reason. Does anyone know the original intent of grep -v ".eh" in this situation?

This would be hugely helpful, and I appreciate any feedback.

@phillip-martin phillip-martin changed the title generate_namespace_generator generate_namespace_generator filtering necessary symbols Jun 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants