Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 128 #129

Merged
merged 9 commits into from
Oct 22, 2020
Merged

Issue 128 #129

merged 9 commits into from
Oct 22, 2020

Conversation

jverzani
Copy link
Owner

Close issue #128

@jverzani jverzani mentioned this pull request Oct 20, 2020
Open
@codecov
Copy link

codecov bot commented Oct 20, 2020 •
edited

Codecov Report

Merging #129 into master will decrease coverage by 0.42%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   82.85%   82.42%   -0.43%     
==========================================
  Files           7        7              
  Lines         525      535      +10     
==========================================
+ Hits          435      441       +6     
- Misses         90       94       +4
Impacted Files Coverage Δ
src/context.jl 82.14% <82.75%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba61ce...4a567d4. Read the comment docs.

GiggleLiu
GiggleLiu reviewed Oct 21, 2020
View reviewed changes
src/context.jl Outdated Show resolved Hide resolved
src/context.jl Outdated Show resolved Hide resolved
GiggleLiu
GiggleLiu reviewed Oct 21, 2020
View reviewed changes
src/context.jl Outdated Show resolved Hide resolved
jverzani and others added 4 commits October 21, 2020 17:09
@jverzani @GiggleLiu
Update src/context.jl
492598f 
Co-authored-by: Leo <cacate0129@gmail.com>
@jverzani @GiggleLiu
Update src/context.jl
06ba6e9 
Co-authored-by: Leo <cacate0129@gmail.com>
@jverzani @GiggleLiu
Update src/context.jl
947a89d 
Co-authored-by: Leo <cacate0129@gmail.com>
@jverzani
add tests; bump version
4a567d4
@GiggleLiu
Copy link
Contributor

Test coverage ↑↑↑↑↑

Thank you!

@jverzani jverzani merged commit edd07f5 into master Oct 22, 2020
@jverzani jverzani deleted the issue_128 branch October 22, 2020 15:48
@jverzani
Copy link
Owner Author

Test coverage ↑↑↑↑↑

Thank you!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiggleLiu GiggleLiu GiggleLiu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jverzani @GiggleLiu