Refactoring #7
Merged
Refactoring #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm renaming the shelltest function to constructor for the sake of being more explicit. This will make sense in light of future refactoring.
The refactor moves the array of setter method names outside of the constructor method.
This commit rethinks the procedural composition of setter methods on the prototype and moves to static assignment of constructor prototype methods.
This commit rethinks the options setter method builder to allow for use on the cmd key.
This commit adds real object types for each expectation, in the form of assertion objects that have an assert method which is called after composition, during evaluation. This approach helps establish separation of concerns, and will be more flexible in the future.
Makes more sense.
Assertions makes more sense.
This commit moves the bulk of Shelltest to the lib directory, but the constructor stays in the entry point. This will help with testing down the road.
They're integration tests really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains significant semantic corrections and style improvements. No known API changes, and little modification to the integration suite.