-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect lone or unescaped brackets and braces when the unicode flag is set #100
Conversation
23661bb
to
d82c010
Compare
Actually, wait... This will cause a Regexpocalypse that will not be easy to fix once this is live (because a codemod would rely on Babel, which would catch the update automatically because the way both Babel and regexpu-core rely on semver). |
I don't think that the situation is as tragic as you picture it, for a few reasons:
|
Let's roll with it then :-) |
Thanks @pygy for providing this! I agree with the arguments outlined by @nicolo-ribaudo and therefore accepted this PR. |
Published new release to npm as v0.6.3 - https://www.npmjs.com/package/regjsparser/v/0.6.3. Thanks once again @pygy ! |
Please see issue #101 . This change introduced a bug. |
Thanks for reporting this. I most likely have some time over the weekend to look into this. @nicolo-ribaudo, @pygy, @jens-duttke Do you think it's better in the meantime to make a new release with the change removed for now? |
I think that it's ok to wait a few days. If you end up not having time to fix it please ping me! |
Digging into this, when reading the JS RegExp gramma, I am not sure why
But https://www.ecma-international.org/ecma-262/10.0/index.html#prod-PatternCharacter Can someone give me a pointer what I am missing here? Once it's clear to me why |
Hi @jviereck
This fixes mathiasbynens/regexpu-core#36 and thus babel/babel#11138
Edit: force push for code styling reasons.