Skip to content

Commit

Permalink
Merge pull request #189 from wmhilton-contrib/issue-188
Browse files Browse the repository at this point in the history
Karma tests properly detect browsers with a space in their name.
  • Loading branch information
John Vilk committed Aug 3, 2017
2 parents df29939 + 20763de commit c1ae1b7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion karma.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const seenBrowsers = {};
const isTravis = process.env.TRAVIS;
// Browser detection does not work properly on Travis.
const installedBrowsers = isTravis ? ['Firefox'] : detectBrowsers.getInstalledBrowsers()
.map(function(browser) { return browser.name; })
// XXX: Browsers with spaces in their name (e.g. Chrome Canary) need to have the space removed
.map(function(browser) { return browser.name.replace(/ /, ''); })
.filter(function(browser) {
if (seenBrowsers[browser]) {
return false;
Expand Down

0 comments on commit c1ae1b7

Please sign in to comment.