Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of document.write to inject polyfill #142

Closed
coltonmercurio opened this issue Apr 28, 2016 · 2 comments
Closed

Replace usage of document.write to inject polyfill #142

coltonmercurio opened this issue Apr 28, 2016 · 2 comments

Comments

@coltonmercurio
Copy link

Currently this unusable an asynchronous module in any browser besides Chrome due to the injection of IEBinaryToArray_ByteStr in all browsers that are not Chrome.

@jvilk
Copy link
Owner

jvilk commented Apr 28, 2016

This shouldn't be an issue; we release BrowserFS as a single UMD module. It should work in RequireJS, Browserify, Webpack, or in a script tag that exposes the BrowserFS global.

@jvilk
Copy link
Owner

jvilk commented Apr 28, 2016

Oh, I see the issue now. We use document.write. But I think that code only gets injected if it's IE?

I will accept a PR that fixes this issue. Perhaps we can inject the script another way, using other DOM methods.

@jvilk jvilk changed the title Support for asynchronous RequireJS Replace usage of document.write to inject polyfill Apr 28, 2016
@jvilk jvilk closed this as completed in 48b2c61 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants