Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.apache.royale #117

Open
yishayw opened this issue Jun 12, 2023 · 5 comments
Open

Add org.apache.royale #117

yishayw opened this issue Jun 12, 2023 · 5 comments

Comments

@yishayw
Copy link

yishayw commented Jun 12, 2023

Hi,

Version 0.9.10 of org.apache.royale is reproducible. What steps do I need to take to add it to your list?

Thanks

@hboutemy
Copy link
Member

i can work on it: is it https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/README.md ?
if not, please provide at least a pointer to the Git repo

@yishayw
Copy link
Author

yishayw commented Jun 13, 2023 via email

@hboutemy
Copy link
Member

as you can see, I tried to rebuild the compiler and found differences between my local build and the reference build from Maven Central: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/royale-maven-plugin-0.9.10.diffoscope

perhaps you can help me improve the buildspec if some issues are cause by inaccurate build instructions: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/royale/compiler/royale-compiler-0.9.10.buildspec

to rebuild as Reproducible Central does, run
./rebuild.sh content/org/apache/royale/compiler/royale-compiler-0.9.10.buildspec

@yishayw
Copy link
Author

yishayw commented Jun 15, 2023

I'll discuss this with the team and see if we can figure this out.

@yishayw
Copy link
Author

yishayw commented Jun 25, 2023

It turns out we do not check src or doc jars for reproducibility, just the binary ones. Also, you are missing "option-with-swf" in the build parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants