Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26 no brackets in variableDeclaratorId #27

Merged
merged 1 commit into from
Mar 28, 2023
Merged

#26 no brackets in variableDeclaratorId #27

merged 1 commit into from
Mar 28, 2023

Conversation

amihaiemil
Copy link
Collaborator

Fixes #26

@zoeself
Copy link
Collaborator

zoeself commented Mar 28, 2023

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@amihaiemil
Copy link
Collaborator Author

@rultor merge it

@zoeself
Copy link
Collaborator

zoeself commented Mar 28, 2023

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@rultor
Copy link
Collaborator

rultor commented Mar 28, 2023

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 43aaf1b into master Mar 28, 2023
@rultor
Copy link
Collaborator

rultor commented Mar 28, 2023

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

@amihaiemil amihaiemil deleted the 26 branch March 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow C-style VariableDeclaratorId Brackets
3 participants