Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28 no C-Style brackets in method declarators #30

Merged
merged 1 commit into from
Mar 28, 2023
Merged

#28 no C-Style brackets in method declarators #30

merged 1 commit into from
Mar 28, 2023

Conversation

amihaiemil
Copy link
Collaborator

Fixes #28

@zoeself
Copy link
Collaborator

zoeself commented Mar 28, 2023

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@amihaiemil
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 28, 2023

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ec36619 into master Mar 28, 2023
@rultor
Copy link
Collaborator

rultor commented Mar 28, 2023

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 2min)

@amihaiemil amihaiemil deleted the 28 branch March 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow C-style Method Declaration Brackets
3 participants
@amihaiemil @zoeself @rultor