Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39 allow 'final' for implementations, fields and params #38

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

amihaiemil
Copy link
Collaborator

@amihaiemil amihaiemil commented Jun 18, 2023

Fixes #39

@zoeself
Copy link
Collaborator

zoeself commented Jun 18, 2023

@amihaiemil thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@amihaiemil amihaiemil changed the title #80 allow 'final' for implementations, fields and params #39 allow 'final' for implementations, fields and params Jun 18, 2023
@amihaiemil
Copy link
Collaborator Author

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Jun 18, 2023

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4f74983 into master Jun 18, 2023
@rultor
Copy link
Collaborator

rultor commented Jun 18, 2023

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 2min)

@amihaiemil amihaiemil deleted the 80 branch June 18, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow 'final' for implementations, fields and params
3 participants