Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty configuration #342

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Allow empty configuration #342

merged 1 commit into from
Aug 12, 2020

Conversation

jvoisin
Copy link
Owner

@jvoisin jvoisin commented Aug 7, 2020 •
edited
Loading 

This commit allows php to run (with a warning) if there
is no specified snuffleupagus configuration,
instead of refusing to start.

@jvoisin jvoisin requested a review from wargio August 7, 2020 14:05
@jvoisin jvoisin changed the title Allow empty configuration [DRAFT] Allow empty configuration Aug 7, 2020
@jvoisin jvoisin marked this pull request as draft August 7, 2020 14:06
@jvoisin jvoisin changed the title [DRAFT] Allow empty configuration Allow empty configuration Aug 7, 2020
This was linked to issues Aug 7, 2020
Disable module (instead of throwing a fatal error) if sp.configuration_file can't be opened #225
Closed
[0.4.0] Could not start (invalid configuration) #236
Closed
Rethink how we're handling no/invalid configuration #239
Closed
@jvoisin jvoisin added this to the 0.6.0 - Elephant in the room milestone Aug 7, 2020
@wargio
Copy link
Collaborator

wargio commented Aug 7, 2020

looks good, but isn't better to use macros for the numbers?

wargio
wargio reviewed Aug 7, 2020
View reviewed changes
src/php_snuffleupagus.h Outdated Show resolved Hide resolved
wargio
wargio reviewed Aug 7, 2020
View reviewed changes
src/snuffleupagus.c Outdated Show resolved Hide resolved
wargio
wargio requested changes Aug 10, 2020
View reviewed changes
src/snuffleupagus.c Outdated Show resolved Hide resolved
src/snuffleupagus.c Show resolved Hide resolved
src/snuffleupagus.c Outdated Show resolved Hide resolved
@jvoisin jvoisin force-pushed the empty_conf branch 4 times, most recently from e4287e7 to e2733e5 Compare August 11, 2020 18:30
@jvoisin
Allow empty configuration
b520a31 
This commit allows php to run (with a warning) if there
is no specified snuffleupagus configuration,
instead of refusing to start.
@wargio wargio marked this pull request as ready for review August 12, 2020 08:40
wargio
wargio approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wargio wargio merged commit a0d21a1 into master Aug 12, 2020
@wargio wargio deleted the empty_conf branch August 12, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0 - Elephant in the room
2 participants
@jvoisin @wargio