Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug: keeps refreshing after date selection #28

Closed
jvolker opened this issue Jul 15, 2021 · 6 comments
Closed

Possible bug: keeps refreshing after date selection #28

jvolker opened this issue Jul 15, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@jvolker
Copy link
Owner

jvolker commented Jul 15, 2021

Posted in #25 by @sankeerthgone

HI , after date selection is any possibility to avoid page refreshing , after date selection and filling captcha its refreshing and coming to start again

@alexDrinkwater do you have a recommendation on how to debug/test this? It seems free spots and therefore alerts are rarer these days. Can we mimic it somehow?

@alexDrinkwater
Copy link
Collaborator

alexDrinkwater commented Jul 15, 2021

@jvolker I am thinking we need to add automated unit testing. I've been looking into it but we may want to change the class on a date to simulate a date being available.

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

Yes, this sounds like a great idea. I don't have a lot of knowledge about testing though. Would you be able to set up a test environment and that particular unit test?

@alexDrinkwater
Copy link
Collaborator

@jvolker I just changed line 115 to var available = document.querySelectorAll('.flatpickr-day.flatpickr-disabled'); and the beep is working fine for me and I don't see any refreshing after a date is found...

@alexDrinkwater
Copy link
Collaborator

@jvolker I'm not able to reproduce this issue on the book assistance. Maybe it was for the chrome extension?

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

@jvolker I'm not able to reproduce this issue on the book assistance.

Thanks for checking @alexDrinkwater. I guess that's a good thing. :)

Maybe it was for the chrome extension?

@sankeerthgone could you please confirm what part of the software you were using - MIQ Booking Assistance (Node.js script) or MIQ Alert (Chrome browser extension)?

@alexDrinkwater
Copy link
Collaborator

Unable to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants