Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building and deploying Electron App #25

Open
jvolker opened this issue Jul 15, 2021 · 17 comments
Open

Building and deploying Electron App #25

jvolker opened this issue Jul 15, 2021 · 17 comments

Comments

@jvolker
Copy link
Owner

jvolker commented Jul 15, 2021

@alexDrinkwater thanks so much for all your work on the Electron app.

I've just been building the app on macOS 11.2.3 (Big Sur). Unfortunately, when opening it I'm receiving this error

image

Big Sur has high-security standards and as a user, you often have to give permissions in multiple places.

I guess we either have to request permission from the user or not access the folder. I'm wondering if we really need to access this? We are not storing or reading anything as far as I can tell.

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

It seems removing this line prevents the error.

@alexDrinkwater Any objections to removing it?

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

Just checked out Github releases and think this is the way to go. I might even be able to build for Windows tonight.

@sankeerthgone
Copy link

HI , after date selection is any possibility to avoid page refreshing , after date selection and filling captcha its refreshing and coming to start again

@alexDrinkwater
Copy link
Collaborator

@jvolker I'm not sure what the user data is for. It was there before I started contributing. Sound like removing it is a good option.

@alexDrinkwater
Copy link
Collaborator

@sankeerthgone that sounds like a newly introduced bug. Can you create a separate issue for it?

@alexDrinkwater
Copy link
Collaborator

@jvolker you can manually create a zip and then upload it to github release. Ideally we use actions to build and create the release.

jvolker added a commit that referenced this issue Jul 15, 2021
This cause an error in macOS Big Sur #25
@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

@jvolker I'm not sure what the user data is for. It was there before I started contributing. Sound like removing it is a good option.

True. :) Removed it.

@jvolker you can manually create a zip and then upload it to github release. Ideally we use actions to build and create the release.

Yes, I'm going to build for Windows when I get access to a PC later today. I hope #28 is not actually breaking it atm.

Github actions sound good. This looks useful:
https://github.com/marketplace/actions/electron-builder-action

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

First release: https://github.com/jvolker/miq-nz-booking-tools/releases/tag/v0.9.0

@alexDrinkwater
Copy link
Collaborator

@jvolker I am wondering if you have instructions on how you build the .exe was it with electron forge?

@jvolker
Copy link
Owner Author

jvolker commented Jul 15, 2021

@jvolker I am wondering if you have instructions on how you build the .exe was it with electron forge?

I've used your instructions from the readme. :) So yes, with Electron Forge.

  1. Install Node.js
  2. Open a command-line window and navigate to the MIQ-Booking-Assistance folder and run npm i to install all dependencies.
  3. npm run make will build the electron application, it outputs it in out folder.

I just had to install Git as well since it was not installed on the machine yet.

@gizelle6
Copy link

A query about refresh which seems to stop the search. The alarm sounds when any date appears in the month selected. If that's not the date required, its not clear how to restart the Assistant other than exiting, reloading the Assistant and logging in again. Maybe there is a shortcut I am missing

@alexDrinkwater
Copy link
Collaborator

@gizelle6 Thanks for the input. Please create a new issue. I think what you are saying is a good idea.

@alexDrinkwater
Copy link
Collaborator

@jvolker Interesting... when I run npm run make the out directory contains many files including an exe. I'm not sure how you were able to condense it down into one file for the application...

@alexDrinkwater
Copy link
Collaborator

@jvolker I was just looking in the wrong folder and see the files you uploaded now. Unfortunately I am on windows and it look like electron-forge can't build for mac when on windows. Could you build the latest for the 0.10.0 release?

@jvolker
Copy link
Owner Author

jvolker commented Jul 19, 2021

Just seeing your message now.

Could you build the latest for the 0.10.0 release?

I did this as mentioned in the PR.

@jvolker
Copy link
Owner Author

jvolker commented Jul 19, 2021

This guide is using Electron forge and Github actions: https://dev.to/erikhofer/build-and-publish-a-multi-platform-electron-app-on-github-3lnd

Maybe the second half with builds only for Releases including draft releases is sufficient.

@jvolker
Copy link
Owner Author

jvolker commented Jul 21, 2021

I've started some work on automated releases but didn't have the time to test it yet: https://github.com/jvolker/miq-nz-booking-tools/tree/automated-releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants