Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac aarch64 artifacts #25

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Fix Mac aarch64 artifacts #25

merged 5 commits into from
Oct 31, 2022

Conversation

rssdev10
Copy link
Contributor

aarch64 instead of a duplicate of x86_64

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 88.02% // Head: 88.02% // No change to project coverage 👍

Coverage data is based on head (2b324b7) compared to base (cef59ee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files           3        3           
  Lines         384      384           
=======================================
  Hits          338      338           
  Misses         46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rssdev10 rssdev10 mentioned this pull request Oct 31, 2022
@jw3126
Copy link
Owner

jw3126 commented Oct 31, 2022

Awesome @rssdev10 looks good to me, but I cannot test. If it works for you, I am willing to merge. Can you also bump the patch version of this package, then I will tag a release!

@rssdev10
Copy link
Contributor Author

Changed the version.
Also, checked internal package tests with mac m1, mac 86_64, win64 and linux64 without CUDA. That works fine.

@jw3126 jw3126 merged commit 961dd5b into jw3126:main Oct 31, 2022
@jw3126
Copy link
Owner

jw3126 commented Oct 31, 2022

Thanks again, I will tag a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants