Axis aware

[briochemc]

This PR is so that we can check that the docs deploy nicely before merging.

There will probably be a bit of more work required to fix the Travis failures that I have ignored so far, too :)

[codecov-io]

Codecov Report

Merging #25 into master will decrease coverage by 12.08%.
The diff coverage is 75.51%.

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
- Coverage   84.14%   72.05%   -12.09%     
===========================================
  Files           1        1               
  Lines          82       68       -14     
===========================================
- Hits           69       49       -20     
- Misses         13       19        +6     

Impacted Files	Coverage Δ
src/UnitfulRecipes.jl	72.05% <75.51%> (-12.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dbe88...45ff062. Read the comment docs.

[briochemc]

One solution is to ignore Julia v1.0 🙈

[jw3126]

I am fine with ignoring 1.0.

[jw3126]

Let see what is the minimal julia version that passes CI

Suggested change

	- "1.0"
	- "1.0"
	- "1.1"
	- "1.2"
	- "1.3"
	- "1.4"

[briochemc]

IMHO we don't need the other julia versions, i.e., CI should restrict itself to only

• 1.0 (long-term-support version, currently v1.0.5)
• 1 (latest stable release, currently v1.4.0)
• nightly (development branch)

So below I just removed 1.0 because it segfaults for some reason I don't understand (and my attempts to analyze and report it following this have failed so far)

[briochemc]

BTW if you are OK with it, I added the GitHub actions for CI to replace the Travis script. Could you do the things I pointed out in #22? (I can't do these myself, it needs to be the repo owner)

[briochemc]

This looks much better than the old implementation. Thanks a lot! Does it get the axes right for histogram?

Oh actually it does not work for histogram... [edited ->] Will point this out onto somehow to Plots.jl / RecipesBase.jl peeps Started a Plots.jl issue about this

[jw3126]

BTW if you are OK with it, I added the GitHub actions for CI to replace the Travis script. Could you do the things I pointed out in #22? (I can't do these myself, it needs to be the repo owner)

Thanks for all of your outstanding work. And sorry that I could not take care of the CI secrets yet and for my slow reviews. Corona converted almost all of my hobby programming time into child care time.

[jw3126]

At first glace this looks good. Thanks a lot! I think travis (and appveyor) should be deleted or alternatively allowed to fail if you think it contains useful information. Can you remind me how to preview the docs?

[briochemc]

Thanks for all of your outstanding work. And sorry that I could not take care of the CI secrets yet and for my slow reviews. Corona converted almost all of my hobby programming time into child care time.

No worries!

[briochemc]

At first glace this looks good. Thanks a lot! I think travis (and appveyor) should be deleted or alternatively allowed to fail if you think it contains useful information. Can you remind me how to preview the docs?

Removed the .travis.yml file in commit 4a3ce10, for which we should see the preview docs from now on I think 🙂

[briochemc]

Well it looks like the PR did not make it into gh-pages... Could you make sure that you re-generate the documenter keys (instructions here) and put the private one in your "secrets" and the replace the public one? And then I can retrigger the docs' GitHub action...

[jw3126]

I think I did everything correctly, but I can redo now just in case.

[jw3126]

I regenerated them. Maybe I forgot to give write access before.

[briochemc]

OK I'll add this new image for the readme just to trigger CI (and make it look a bit nicer?)

[briochemc]

OK it worked, here is the preview: https://jw3126.github.io/UnitfulRecipes.jl/previews/PR25/

[briochemc]

Is it OK for me to merge and tag a release?

[jw3126]

LGTM feel free to merge and tag a release. And thanks again for this great PR. Code is much cleaner now.

[daschw]

I don't want to promise too much but the segfault on julia 1.0 could be caused by a faulty precompiles file in Plots and might be fixed with the next Plots release.