-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac M1 support #22
Comments
Sure if it is already a tarball you can just add it to Artifacts.toml. If not we need to repackage it. Happy to guide a PR if you want to give it a shot. |
If I understand right, all the binaries are available. And, number of supported architectures in general is much higher compared with the previous version. But, the first step - somebody have to upload these files to If you explain me how to do it, I can check ONNXRunTime with both Mac architectures. But I don't have other architectures. And, if you have some script for automation generating the following descriptions and check sums, it would be good to have it too:
|
Repackaging to ONNXRunTimeArtifacts should only be necessary for windows. The other binaries can be taken directly from |
With #24 merged, it should now be easier for you to add M1 support. |
I use this script, in case you need to adapt it: https://github.com/jw3126/ONNXRunTimeArtifacts/blob/main/script.jl |
Thanks, but a minor fix for the script: (
artifact_name="onnxruntime_cpu",
download_name="onnxruntime-osx-universal2-$version.tgz",
platform=Pkg.Artifacts.Platform("x86_64", "macos"),
version=version,
),
(
artifact_name="onnxruntime_cpu",
download_name="onnxruntime-osx-universal2-$version.tgz",
platform=Pkg.Artifacts.Platform("aarch64", "macos"),
version=version,
), |
and, with #25 that works on M1. |
fixed by #25 if some issues remain, please reopen. |
Hello, is any way to update binary dependencies https://github.com/jw3126/ONNXRunTime.jl/blob/main/Artifacts.toml
by https://github.com/microsoft/onnxruntime/releases/tag/v1.13.1 ?
For Mac M1 there is a universal archive
onnxruntime-osx-universal2-1.13.1.tgz
with both arm64 and amd64 platforms.The text was updated successfully, but these errors were encountered: