Allow setting password for user without password #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user does not have rep:password code fails with: Caused by NoMethodError: undefined method `match' for nil:NilClass /var/chef/cache/cookbooks/cq/libraries/provider_cq_user.rb:246:in `hash_decoder' /var/chef/cache/cookbooks/cq/libraries/provider_cq_user.rb:268:in `hash_generator' /var/chef/cache/cookbooks/cq/libraries/provider_cq_user.rb:295:in `password_update?' /var/chef/cache/cookbooks/cq/libraries/provider_cq_user.rb:70:in `modify_user' The problem is that ruby evaluates hash_generator(new_pass) before checking if end_with? can be called on nil.
|
Hi @jgorgolewski. Thanks for the PR! I'm swamped with work recently, but promise to have a look at that by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user does not have rep:password code fails with:
The problem is that ruby evaluates hash_generator(new_pass) before checking if end_with? can be called on nil.