Issue #18: Loop on array indices instead of for..in

jwagener-soundcloud · Nov 29, 2012 · 3cfd417 · 3cfd417
1 parent d881366
commit 3cfd417
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/recorder.js b/recorder.js
@@ -108,9 +108,12 @@ var Recorder = {
 
   triggerEvent: function(eventName, arg0, arg1){
     Recorder._executeInWindowContext(function(){
-      for(var cb in Recorder._events[eventName]){
-        if(Recorder._events[eventName][cb]){
-          Recorder._events[eventName][cb].apply(Recorder, [arg0, arg1]);
+      if (!Recorder._events[eventName]) {
+        return;
+      }
+      for(var i = 0, len = Recorder._events[eventName].length; i < len; i++){
+        if(Recorder._events[eventName][i]){
+          Recorder._events[eventName][i].apply(Recorder, [arg0, arg1]);
         }
       }
     });