Fix incorrect inference in bulk::sum and bulk::product
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmaarse
changed the title
bulk::sumbulk::sum and bulk::product
|
Great, thanks! If you want, you can add yourself to the 'also thanks to' section of the README :) |
jwbuurlage
approved these changes
Oct 8, 2020
jwbuurlage
approved these changes
Oct 8, 2020
|
Thank you for the quick response and the library itself! If I have another PR I will add myself to the "also thanks to" section 😉 |
|
Thanks again! And please do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the overloads of
bulk::sumandbulk::producttakingworldreferences, this PR fixesstd::accumulatespecializing tointregardless of the argument types and adds a few tests.This implementation requires that
1can be cast toTinbulk::product, which can be fixed (we can reduce without a unit element), but I noticed this is also already the case for the otherproductoverload.