Remove SlugHelper from constructor argument

jweiland-net · May 25, 2021 · f8e7fe3 · f8e7fe3
1 parent 116e176
commit f8e7fe3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 15 deletions.
diff --git a/Classes/Updates/SlugUpdateWizard.php b/Classes/Updates/SlugUpdateWizard.php
@@ -39,19 +39,6 @@ class SlugUpdateWizard implements UpgradeWizardInterface
      */
     protected $slugHelper;
 
-    public function __construct(SlugHelper $slugHelper = null)
-    {
-        if ($slugHelper === null) {
-            $slugHelper = GeneralUtility::makeInstance(
-                SlugHelper::class,
-                $this->tableName,
-                $this->fieldName,
-                $GLOBALS['TCA'][$this->tableName]['columns']['path_segment']['config']
-            );
-        }
-        $this->slugHelper = $slugHelper;
-    }
-
     /**
      * Return the identifier for this wizard
      * This should be the same string as used in the ext_localconf class registration
@@ -145,6 +132,20 @@ public function executeUpdate(): bool
         return true;
     }
 
+    protected function getSlugHelper(): SlugHelper
+    {
+        if ($this->slugHelper === null) {
+            $this->slugHelper = GeneralUtility::makeInstance(
+                SlugHelper::class,
+                $this->tableName,
+                $this->fieldName,
+                $GLOBALS['TCA'][$this->tableName]['columns']['path_segment']['config']
+            );
+        }
+
+        return $this->slugHelper;
+    }
+
     /**
      * @return string[]
      */

diff --git a/Documentation/Changelog/Index.rst b/Documentation/Changelog/Index.rst
@@ -6,4 +6,6 @@
 Change log
 ==========
 
-...
+**Version 4.0.3**
+
+- Move SlugHelper from constructor argument into getSlugHelper()
diff --git a/Documentation/Settings.cfg b/Documentation/Settings.cfg
@@ -25,7 +25,7 @@ project     = daycarecenters
 # ...   (recommended) version, displayed next to title (desktop) and in <meta name="book-version"
 # .................................................................................
 
-release     = 4.0.0
+release     = 4.0.3
 
 # .................................................................................
 # ...  (recommended) displayed in footer