Merge pull request #315 from jweiland-net/doNotStoreMessageInBeSession

Do not store message in be session
jweiland-net · Mar 5, 2024 · eba2981 · eba2981
2 parents adce7cd + 8470fa2
commit eba2981
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/Classes/Helper/MessageHelper.php b/Classes/Helper/MessageHelper.php
@@ -11,6 +11,7 @@
 
 namespace JWeiland\Maps2\Helper;
 
+use TYPO3\CMS\Core\Core\Environment;
 use TYPO3\CMS\Core\Messaging\AbstractMessage;
 use TYPO3\CMS\Core\Messaging\FlashMessage;
 use TYPO3\CMS\Core\Messaging\FlashMessageQueue;
@@ -38,7 +39,7 @@ public function addFlashMessage(string $message, string $title = '', int $severi
             $message,
             $title,
             $severity,
-            true
+            !Environment::isCli()
         );
 
         $this->getFlashMessageQueue()->enqueue($flashMessage);

diff --git a/Documentation/ChangeLog/Index.rst b/Documentation/ChangeLog/Index.rst
@@ -7,6 +7,11 @@
 ChangeLog
 =========
 
+Version 10.0.12
+===============
+
+*   BUGFIX: Do not store FlashMessages in BE session in CLI context
+
 Version 10.0.11
 ===============
 

diff --git a/Documentation/Settings.cfg b/Documentation/Settings.cfg
@@ -22,7 +22,7 @@
 
 project     = maps2 (Maps2)
 version     = 10.0
-release     = 10.0.11
+release     = 10.0.12
 t3author    = Stefan Froemken
 copyright   = since 2013 by jweiland.net
 

diff --git a/Tests/Functional/Helper/MessageHelperTest.php b/Tests/Functional/Helper/MessageHelperTest.php
@@ -59,7 +59,7 @@ public function addFlashMessageWithMessageCallsEnqueue(): void
             'Hello',
             '',
             AbstractMessage::OK,
-            true
+            false
         );
 
         $this->subject->addFlashMessage('Hello');
@@ -79,7 +79,7 @@ public function addFlashMessageWithMessageAndSubjectCallsEnqueue(): void
             'Hello',
             'Subject',
             AbstractMessage::OK,
-            true
+            false
         );
 
         $this->subject->addFlashMessage('Hello', 'Subject');
@@ -99,7 +99,7 @@ public function addFlashMessageWithAllArgumentsCallsEnqueue(): void
             'Hello',
             'Subject',
             AbstractMessage::ERROR,
-            true
+            false
         );
 
         $this->subject->addFlashMessage('Hello', 'Subject', AbstractMessage::ERROR);

diff --git a/ext_emconf.php b/ext_emconf.php
@@ -3,7 +3,7 @@
 $EM_CONF[$_EXTKEY] = [
     'title' => 'Maps2',
     'description' => 'Create maps with Marker, Area, Routes or Radius based on Google Maps or OpenStreetMap',
-    'version' => '10.0.11',
+    'version' => '10.0.12',
     'category' => 'plugin',
     'state' => 'stable',
     'clearCacheOnLoad' => true,