Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TYPO3 v11] PoiCollection from Flexform Settings is never used #241

Closed
EvilBMP opened this issue Feb 13, 2022 · 1 comment
Closed

[TYPO3 v11] PoiCollection from Flexform Settings is never used #241

EvilBMP opened this issue Feb 13, 2022 · 1 comment

Comments

@EvilBMP
Copy link

EvilBMP commented Feb 13, 2022

In Plugin "maps2_maps2" the selected PoiCollection is never used in the v11 branch. The check was removed in the "refactored" showAction of the PoiController. But it is also missing the PoiCollectionRepository->findPoiCollections(). So was this removed by intention or is it just a bug?

@froemken
Copy link
Contributor

froemken commented Mar 2, 2022

Hello @EvilBMP

thank you for this issue report.
I stumbled over this issue just yesterday.
I had forgotten to copy a condition. Now it works again.

Further there was following check: is_string($settings['categories']) which, of cause, will always add category constraint to query. I have changed that just yesterday, too.

As these changes are already merged into master I close this issue

Stefan

@froemken froemken closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants