Two small fixes that help this compile with the LLVM shipped in Xcode 4.3.2. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
th-in-gs
commented
May 14, 2012
th-in-gs
commented
- Include UIKit.h in one of the files that was using CGFloat, but only including Foundation.h
- A few casts of private NSMutableArrays to cope with LLVM's different idea of how properties override method declarations.
…r in the test app before).
…y before mutating them. Latest LLVMs don't recognise the NSMutable array property in the class extension as 'overriding' the declared NSArray accessor in the class definition (in the header). Casting here makes the code compile. This does feel a bit messy, but I think it's pretty clear that it's safe, and it feels /less/ wordy than adding special mutation accessors.
jweinberg
added a commit
that referenced
this pull request
May 15, 2012
Two small fixes that help this compile with the LLVM shipped in Xcode 4.3.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.