Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase EventMachine dependency version to 1.0.7 #33

Closed
v0dro opened this issue Apr 10, 2015 · 6 comments
Closed

Increase EventMachine dependency version to 1.0.7 #33

v0dro opened this issue Apr 10, 2015 · 6 comments

Comments

@v0dro
Copy link
Contributor

v0dro commented Apr 10, 2015

I'm facing some problems with building EventMachine 1.0.3 native extensions (a possible fix is given here.

Increasing the version to 1.0.7 (latest) fixes the issue.

@v0dro
Copy link
Contributor Author

v0dro commented Apr 10, 2015

And I think this issue arises only on ruby 2.2.0

@jwhitehorn
Copy link
Owner

My schedule doesn't give me enough time to really work on this project at the moment, but I'd gladly accept a pull request.

@v0dro
Copy link
Contributor Author

v0dro commented Apr 10, 2015

Sure thing!

Also could you tell me if there is anything specific that I should keep in mind during testing?

@elmatou
Copy link
Contributor

elmatou commented May 5, 2015

Same here, happend only with ruby 2.2.x . Eventmachine 1.0.4 (a later) fix this.

@elmatou
Copy link
Contributor

elmatou commented Feb 7, 2016

EventMachine dependency could be withdrawn.
It is only used for PiPiper#spi_poll which could be done with a simple sleep in a loop. Other Implementations, with EventMachine, Celluloid, Cool.io, Thread, Fiber.... should be done in application code.

@zsyed91
Copy link
Collaborator

zsyed91 commented Feb 8, 2016

I agree with @elmatou. If we can move this into the actual app code then it should reduce complexity of the gem. But anyhow, the current changes going into 1.9.9 which hopefully should be released in the next day or so contains the latest version of EventMachine. So this issue should be resolved once that is released. I am going to go ahead and close this.

@zsyed91 zsyed91 closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants