Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dired-async broken with remote files #80

Open
thierryvolpiatto opened this issue Jul 30, 2017 · 4 comments
Open

dired-async broken with remote files #80

thierryvolpiatto opened this issue Jul 30, 2017 · 4 comments

Comments

@thierryvolpiatto
Copy link
Collaborator

It is working fine with emacs-24.5, didn't try with emacs-25*, here the buffers with async-debug enabled:

With emacs-24.5:

Lisp expression: Tramp: Opening connection for root@dell-14z using sudo...
Opening connection for root@dell-14z using sudo... \
Tramp: Sending command `exec env SHELL=/bin/sh sudo -u root -s -H -p Password:'
Tramp: Waiting for prompts from remote shell...
Waiting for prompts from remote shell... \
Tramp: Sending Password
Decrypting /home/thierry/.authinfo.gpg...0%
Decrypting /home/thierry/.authinfo.gpg...done
[...]

Here with emacs-26:

Lisp expression: Tramp: Opening connection for root@dell-14z using sudo...
Opening connection for root@dell-14z using sudo... \
Tramp: Sending command ‘exec env SHELL=/bin/sh sudo -u root -s -H -p P""a""s""s""w""o""r""d"":’
Tramp: Waiting for prompts from remote shell...
Waiting for prompts from remote shell... \
Tramp: Sending Password
Password for /sudo:root@dell-14z: 

Now hanging on password prompt whereas we are never prompted with emacs-24.5

I will try to find what's wrong here though it's hard to debug, if someone can help he is welcome...

@thierryvolpiatto
Copy link
Collaborator Author

Working fine on emacs-25.2, so the bug happen only on emacs-26

@thierryvolpiatto
Copy link
Collaborator Author

Working fine also with scp method and emacs-26, so I guess it is only a problem with sudo method.
I didn't try yet multi hop i.e scp+sudo.

@thierryvolpiatto
Copy link
Collaborator Author

I finally found where the bug have been introduced in Emacs Master branch:

164fcc6f26e * Fix Bug#27315

Perhaps somebody can report upstream @jwiegley ?

To reproduce the bug from master emacs, it's easy:

  1. enable dired-async-mode
  2. Copy a local file to "/sudo::/somewhere", the child emacs will hang forever waiting user interaction for password.

As soon as you switch to 5647c4a2c62 (previous commit) it starts to work again.

thierryvolpiatto added a commit that referenced this issue Aug 3, 2017
* async.el (async-start): Do it.
thierryvolpiatto added a commit that referenced this issue Aug 4, 2017
* async.el (async-quiet-switch): Do it.
(async-start):                   Do it.
@thierryvolpiatto
Copy link
Collaborator Author

I finally found a workaround by allowing using the emacs "-q" option instead of "-Q" in async.
But IMO this should be fixed upstream in tramp directly (tramp should take care of not breaking external packages).

thierryvolpiatto added a commit that referenced this issue Aug 30, 2017
* async.el (async-start): Do it.
thierryvolpiatto added a commit that referenced this issue Aug 30, 2017
* async.el (async-quiet-switch): Do it.
(async-start):                   Do it.
thierryvolpiatto added a commit to emacs-helm/helm that referenced this issue Jun 11, 2018
See jwiegley/emacs-async#80.

* helm-files.el (helm-delete-marked-files-async): Use
async-quiet-switch == -q.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant