Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple :delight arguments, or omitting the mode. (#477) #480

Merged
merged 2 commits into from Jul 2, 2017
Merged

Allow multiple :delight arguments, or omitting the mode. (#477) #480

merged 2 commits into from Jul 2, 2017

Conversation

joewreschnig
Copy link
Contributor

This allows using forms such as

(use-package foo :delight)
    ;; => (delight 'foo-mode)
(use-package foo :delight " f")
    ;; => (delight 'foo-mode " f")
(use-package foo :delight (a-mode) (b-mode " b")
    ;; => (delight 'a-mode) (delight 'b-mode " b")

This brings support for :delight in line with :diminish.

@joewreschnig
Allow multiple :delight arguments, or omitting the mode. (jwiegley#477)
7b1b829 
This allows using forms such as

    (use-package foo :delight)
        ;; => (delight 'foo-mode)
    (use-package foo :delight " f")
        ;; => (delight 'foo-mode " f")
    (use-package foo :delight (a-mode) (b-mode " b")
        ;; => (delight 'a-mode) (delight 'b-mode " b")

This brings support for `:delight` in line with `:diminish`.
@joewreschnig
Allow :major as the third argument in :delight calls.
722d758
@joewreschnig
Copy link
Contributor Author

The first patch retained the original code's forced quoting of the third argument, which is not correct when the third argument is :major. This is handled correctly now. As a result all :delight forms for one package are compressed into one (delight ...) call, which is probably nicer to read in most cases.

@jwiegley jwiegley merged commit fd462e8 into jwiegley:master Jul 2, 2017
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 24, 2022
@jwiegley
Merge pull request from joewreschnig/477-delight-wrappers
3f72951 
Allow multiple :delight arguments, or omitting the mode. (jwiegley/use-package#477)
GitHub-reference: jwiegley/use-package#480
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 29, 2022
@jwiegley
Merge pull request from joewreschnig/477-delight-wrappers
463e38b 
Allow multiple :delight arguments, or omitting the mode. (jwiegley/use-package#477)
GitHub-reference: jwiegley/use-package#480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joewreschnig @jwiegley