New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice #850
Conversation
…ng :custom vars twice
Tue Jun 30 11:14:51 BST 2020 HI,
|
@tzz This broke the test. In addition, you need to fix the docstring too. Please fix them. |
@tzz |
Actually you don't need all the complexity of |
After jwiegley/use-package#850, did the following to eliminate duplicate variable definitions in custom.el and init.el: - Removed from custom.el all variables that are configured in init.org - Changed all uses of customize-set-variable to custom-set-variables.
why do you use |
Sadly this breaks my workflows. Not to say the change should be rolled back, yet something needs to be figured. I'll follow up. |
of course, I'm wondering /why/ one may want to use both |
Unfortunately, And there are many such commands in Emacs that use |
See also https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg00306.html |
@link0ff please see #881 for an attempt to resolve this issue with regards to custom variables. I think a similar fix for custom faces is possible but am not sure, considering this is the filter applied to them:
What do you think? Thanks to everyone who chimed in, and apologies for the late followup. |
Thanks, it seems this is the right fix for now (later custom.el could be improved to save customizations to the same place where they were loaded, but this is much larger redesign of custom.el). Regarding the custom faces: like you put |
use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice GitHub-reference: jwiegley/use-package#850
GitHub-reference: jwiegley/use-package#850
GitHub-reference: jwiegley/use-package#850
use-package-core.el: use the Emacs set-default function to avoid saving :custom vars twice GitHub-reference: jwiegley/use-package#850
GitHub-reference: jwiegley/use-package#850
GitHub-reference: jwiegley/use-package#850
This was discussed in #517 and I CC-ed @jwiegley on the emacs-devel discussion.
The change will ensure that
:custom
vars are not also saved to custom.el.In my testing it worked correctly, I don't see custom.el entries for those variables anymore. Testing is welcome!