use-package-with-elapsed-timer: respect option at runtime

[tarsius]

Previously the option use-package-verbose was consulted at macro
expansion time, and as a result customizing the option did nothing,
without also recompiling use-package.el.

The other two commits are cosmetics.

[Silex]

What does use-package-with-elapsed-timer do? is it related to #77?

[jwiegley]

use-package-with-elapsed-timer displays elapsed loading time for either packages that take a long time to load, or for all packages if verbosity is enabled.

[Silex]

Ah, ok so it's not something you use directly. I've been using it without knowing it because of (setq use-package-verbose t) in my config :)

[YoungFrog]

Why add use-package-with-elapsed-timer to font locking ? It's an internal macro isn't it ?

[tarsius]

It probably was intended as that initially, but it is actually quite useful in places where you would also use use-package. E.g. I use it several times in my init.el. One of these uses wraps everything but loading use-package itself :-) But it would be good if it had a doc-string.

[npostavs]

@jwiegley: shouldn't that be
use-package-with-elapsed-timer displays elapsed loading time for either packages that take a long time to load or for all packages only if verbosity is enabled.

I'm wondering if I accidentally changed it from the original intention in 0b088fb, though as far as I can tell, it was always this way.

But it would be good if it had a doc-string.

Yup.

[jwiegley]

No, it always reports really long load times.

[npostavs]

No, it always reports really long load times.

hmm

(let ((use-package-verbose nil))
  (pp-macroexpand-expression
   '(use-package-with-elapsed-timer "text"
      (do-stuff))))

=>

(progn
  (do-stuff))

That's before this patch, now the if is at runtime instead, but the effect is the same.

[jwiegley]

I don't understand. So what has changed exactly?

[npostavs]

I don't think the behaviour has changed, but it doesn't appear to match your description.