Use state property in xlf-files #17 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 5, 2019 23:52
|
Does readme.md require any modifications/additions? |
|
Yes. The readme needs some work to reflect the new possibilities. No default behaviour has changed tho. I'll get back with an update. |
jwikman
requested changes
Dec 7, 2019
There was a problem hiding this comment.
- GetTransUnitLineType() needs to be updated, right now F12 fails if inside a trans-unit with the new state attribute ('Not inside a trans-unit element')
- When refreshing from g.xlf and
target-language==source-language, it should copy source to target, and set attributestate="needs-review-translation"
added 7 commits
December 8, 2019 13:48
|
A part from the question about wrap search all comments are resolve from my point of view. |
jwikman
requested changes
Dec 8, 2019
added 2 commits
December 8, 2019 23:00
jwikman
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to solve issue #17 .
New setting
NAB.UseExternalTranslationToolthis setting modifies the target state attribute instead of inserting a searchable string.When searching for all and next untranslated texts and
NAB.UseExternalTranslationTool == truethe state attribute is searched.New setting
NAB.ReplaceSelfClosingXlfTagsdefault true. This regulates the use of functionality was added for issue Empty elements are replaced with self-closing tags #5. If set to false no self-closed tags are replaced in xlf-files.Update README.md.