Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiting for udp, udp4 and udp6 ports. #26

Merged
merged 2 commits into from
Jan 27, 2016
Merged

Conversation

metmajer
Copy link
Contributor

As discussed in Issue #25.

jwilder added a commit that referenced this pull request Jan 27, 2016
Add waiting for udp, udp4 and udp6 ports.
@jwilder jwilder merged commit 88f4faa into jwilder:master Jan 27, 2016
@jwilder
Copy link
Owner

jwilder commented Jan 27, 2016

Thanks @metmajer!

@metmajer
Copy link
Contributor Author

Welcome @jwilder! Can you please craft a release?

@metmajer metmajer mentioned this pull request Jan 27, 2016
@metmajer
Copy link
Contributor Author

Don't release for now, implementation is flawed: for udp-like schemes net.DialTimeout returns immediately even if the port is not open. Unfortunately, err is always nil. Going to have a look into it. Feel free to revert and I'll submit a PR again if I can make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants