Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~/.local/share/sinntp/ documentation #10

Open
jwilk opened this issue Apr 26, 2014 · 4 comments
Open

~/.local/share/sinntp/ documentation #10

jwilk opened this issue Apr 26, 2014 · 4 comments

Comments

@jwilk
Copy link
Owner

jwilk commented Apr 26, 2014

Issue reported by randomcoder1 at Google Code:

Hi, can you please add more documentation on what the integers in files in ~/.local/share/sinntp/ mean.
My guess is they are intended for sinntp to know where it left off, but I'm not sure.
Also, my apologies if I missed any part of the current documentation that described is.

@jwilk
Copy link
Owner Author

jwilk commented Apr 26, 2014

You guessed right; this number is identifier of the last successfully downloaded article.
But this is in an implementation detail, and as such it is subject to change in the future versions.
I'd rather leave the format undocumented, but I don't have strong feelings about it. @l9i, what do you think?

@jwilk
Copy link
Owner Author

jwilk commented Apr 27, 2014

Comment submitted by randomcoder1 at Google Code:

I'll give a little bit more background on why I'm asking this(I should have in my first message).

Suppose sinntp is killed with kill -9, are there explicit/implicit handlers whether in sinntp itself or outside of it that take care of writing the current state to ~/local/share/sinntp.

And two more related questions:
Is SIGKILL the right signal for terminating a sinntp process ?
If SIGKILL is not the right signal, what signal should be used to allow sinntp to gracefully exit ?

Thanks

@jwilk
Copy link
Owner Author

jwilk commented Apr 29, 2014

SIGKILL is almost never the right signal. It should be used only as last resort.

SIGTERM is the generic signal for program termination. Unfortunately, sinntp doesn't currently handle it gracefully. This is something that we ought to fix.

As a temporary work-around you can use SIGINT, which is handled correctly AFAICT.

@jwilk
Copy link
Owner Author

jwilk commented Apr 30, 2014

I've opened issue #15 to track SIGTERM handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant