Input method select list position is not correct

[chrisniael]

MacOS Mojave 10.14.2
Alacritty v0.2.7

[chrisduerr]

Note this is not macOS-specific, but has been reproduced on Linux in #2061.

[chrisduerr]

Also, the following patch puts the IME update after potential terminal resize events, could you let me know if this fixes the problem?

diff --git a/src/main.rs b/src/main.rs
index a5564cd..f362319 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -233,16 +233,16 @@ fn run(
 
         // Maybe draw the terminal
         if terminal_lock.needs_draw() {
-            // Try to update the position of the input method editor
-            #[cfg(not(windows))]
-            display.update_ime_position(&terminal_lock);
-
             // Handle pending resize events
             //
             // The second argument is a list of types that want to be notified
             // of display size changes.
             display.handle_resize(&mut terminal_lock, &config, &mut [&mut resize_handle, &mut processor]);
 
+            // Try to update the position of the input method editor
+            #[cfg(not(windows))]
+            display.update_ime_position(&terminal_lock);
+
             drop(terminal_lock);
 
             // Draw the current state of the terminal

[pickfire]

@chrisduerr Why not update ime position after redraw?

[chrisduerr]

Redrawing shouldn't do anything special to mutate the terminal state.

If my patch doesn't work though, feel free to try that too.

[awused]

@chrisduerr That patch does not fix the issue for me, the IME position is unchanged.

I quickly fixed it for myself by dividing nspot_x and nspot_y in update_ime_position by hidpi_factor.

[chrisduerr]

Not taking DPI into account, sounds like a very likely cause for this problem! Thanks for looking into this @awused, unfortunately I'm completely unfamiliar with IME.

Would you mind sending a PR? I'll gladly help out with style or other issues if there still are some.

[chrisniael]

@chrisduerr , @awused 's PR code works fine for me.