Make windows config location more sensible #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
requested changes
Dec 2, 2018
There was a problem hiding this comment.
Thanks for the PR, I've got just some minor comments for the changes made here.
It looks like this PR is only using dirs for Windows at the moment, but xdg is still used for macOS. I'm not familiar with the exact functionality of dirs, but would it be possible to make use of it on Linux too, so we can reduce the number of dependencies?
|
Using They follow the same usual case if I think it's probably not worth the effort. |
chrisduerr
force-pushed
the
windows-config-location
branch
4 times, most recently
from
b5eb7e8
to
ccfe863
Compare
The change log entry has been reworded and some minor code refactoring has been done.
chrisduerr
force-pushed
the
windows-config-location
branch
from
ccfe863
to
d2b3f6e
Compare
The current behavior incorrectly created the `alacritty/alacritty.yml` directory, instead of making `alacritty.yml` a file. This has been fixed by creating all directories for the parent of the target file, instead of the file itself.
chrisduerr
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to my initial idea this does not remove platform specific code, mostly because after dealing with fallbacks and supporting the old windows location it's not worth it.
This changes the configuration file location from (in fallback order):
%HOME%\alacritty.yml%USERPROFILE%\alacritty.ymlGetUserProfileDirectory()\alacritty.ymlTo:
%APPDATA%\Roaming\alacritty\alacritty.ymlIf a configuration file is found in the old location a warning is emitted pointing to the new location.
Fixes #1660