-
Notifications
You must be signed in to change notification settings - Fork 24
Newline chars in function signatures #21
Comments
Thanks for filing the issue!
I've been thinking it would be nice to clean up the signatures in the completemenu, and this sounds like an easy thing to do for now. In the future, Racer will hopefully offer more granular signature info - return type, where clauses, arguments as separate properties. Since this project will need to be updated when that happens anyway, this seems like a fine place to make the whitespace change. If you're feeling really ambitious, our iteration over matches from Racer would probably be a good place to apply this transformation. Otherwise, I'll get to this... eventually. |
@jwilm Thanks for pointing me in the right direction; I might just send you a PR! :) |
I love PRs! |
PR #22 created! :) |
Updating to latest racerd We'd like to pick up the fix for jwilm/racerd#21. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/329) <!-- Reviewable:end -->
Testcase code
Completion shown in Vim through YCM:
One could consider this a bug in ycmd since it might make sense to remove the newline there, or possibly in YCM itself because the newline doesn't render sensibly in Vim so the Vim workaround should be there, but racerd (or racer itself) should probably not be returning a newline here either. I can't imagine an editor for which a newline should be displayed here.
I'd suggest replacing all whitespace char runs with a single space... somewhere.
(We're "turtles all the way down" on this bug...)
The text was updated successfully, but these errors were encountered: