vertical option for slider (#204)

* vertical option for slider * convert to js bool
jwkvam · Feb 10, 2018 · 6d84e15 · 6d84e15
1 parent c133fc5
commit 6d84e15
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/bowtie/control.py b/bowtie/control.py
@@ -607,10 +607,11 @@ class Slider(_Controller):
               'max={{{maximum}}} '
               'step={{{step}}} '
               'start={{{start}}} '
-              'marks={{{marks}}}')
+              'marks={{{marks}}} '
+              'vertical={{{vertical}}}')
 
     def __init__(self, start=None, ranged=False, minimum=0, maximum=100, step=1,
-                 caption=None):
+                 vertical=False, caption=None):
         """Create a slider.
 
         Parameters
@@ -626,6 +627,8 @@ def __init__(self, start=None, ranged=False, minimum=0, maximum=100, step=1,
             Maximum value of the slider.
         step : number, optional
             Step size.
+        vertical : bool, optional
+            If True, the slider will be vertical
         caption : str, optional
             Heading text.
 
@@ -648,7 +651,8 @@ def __init__(self, start=None, ranged=False, minimum=0, maximum=100, step=1,
             maximum=maximum,
             start=start,
             step=step,
-            marks={minimum: str(minimum), maximum: str(maximum)}
+            marks={minimum: str(minimum), maximum: str(maximum)},
+            vertical=jsbool(vertical)
         )
 
     # pylint: disable=no-self-use

diff --git a/bowtie/src/slider.jsx b/bowtie/src/slider.jsx
@@ -88,6 +88,7 @@ export default class AntSlider extends React.Component {
                 max={this.state.max}
                 step={this.props.step}
                 marks={this.props.marks}
+                vertical={this.props.vertical}
                 onChange={this.onChange}
                 onAfterChange={this.onAfterChange}
             />
@@ -107,4 +108,5 @@ AntSlider.propTypes = {
     ]).isRequired,
     step: PropTypes.number.isRequired,
     marks: PropTypes.object.isRequired,
+    vertical: PropTypes.bool.isRequired
 };